-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the DS project list toggle #3018
Conversation
@kywalker-rh @xianli123 could you please take a look the UI changes? screenshot of the image I am talking about for ref: |
frontend/src/pages/projects/screens/projects/ProjectTableRow.tsx
Outdated
Show resolved
Hide resolved
I'll step in here 🙂 Yes, we do need to get rid of the identifier. We are looking to get so far away from this concept of "Data Science Projects are different" that we are even RFE-ing a rename of this page to just |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested locally! Awesome to finally have this weird toggle gone.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gitdallas, mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-9576
Description
This PR aims to remove the DS project list toggle.
How Has This Been Tested?
In DS list page, we will not be having a toggle to switch projects.
Test Impact
Updated cypress test.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main